Skip to content

Conversation

@erickzhao
Copy link
Member

@erickzhao erickzhao commented Dec 12, 2025

A little re-organization of our slow tests to minimize CI time (reduces the number of tests a bit) and make the tests easier to read.

  1. Instead of running a describe.each loop for each supported package manager, run a single describe block asserting the expected characteristics of each (node_modules is in expected format and lockfile is correct).
  2. Move all other tests outside of this
  3. Get rid of beforeInitTest and instead call api.init in each test so it's more intuitive. Vitest timings become more accurate because api.init time is accounted for within each test as well.
  4. Separate bootstrap tests into separate import and init files.

@erickzhao erickzhao marked this pull request as ready for review December 12, 2025 23:24
@erickzhao erickzhao requested a review from a team as a code owner December 12, 2025 23:24
@erickzhao erickzhao merged commit 02d388a into next Dec 12, 2025
14 checks passed
@erickzhao erickzhao deleted the test/simplify-slow-init-import branch December 12, 2025 23:33
github-merge-queue bot pushed a commit that referenced this pull request Dec 19, 2025
* test(slow): test api against `file:` protocol fixtures (#4087)

* test(slow): simplify bootstrapping tests (#4096)

* test: use verdaccio for e2e init testing (#4100)

* zzz

* gg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants