fix(template): add private: true
#4103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikwen
approved these changes
Dec 18, 2025
| ).toEqual(true); | ||
| expect(fs.existsSync(path.join(dir, 'forge.config.js'))).toEqual(true); | ||
|
|
||
| // init should create a `private: true` npm package |
Member
There was a problem hiding this comment.
Shouldn't this be a separate it('should create a "private: true" npm package')?
Member
Author
There was a problem hiding this comment.
I refactored the tests a bit this week to make api.init part of the test instead of hiding it in a beforeEach() helper. I think this makes the Vitest output less descriptive but makes understanding the test flow easier.
VerteDinde
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4101 but for
next