fix: assorted bug fixes and comment corrections#211
Open
MarshallOfSound wants to merge 4 commits intomainfrom
Open
fix: assorted bug fixes and comment corrections#211MarshallOfSound wants to merge 4 commits intomainfrom
MarshallOfSound wants to merge 4 commits intomainfrom
Conversation
The zero-padding logic checked `monthIndex < 10` but outputs `monthIndex + 1`, so October (monthIndex=9) produced `/history/2025-010-15` instead of `/history/2025-10-15`, resulting in broken links. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace non-null assertions with optional chaining and add an early return when no nightly or stable release is found. Prevents a server crash if the upstream releases API returns an empty array. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace brittle split('#')[1] with a regex match and add a guard
that returns a safe default when no PR number can be extracted,
preventing NaN from being passed to the GitHub API.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comments said "10 seconds" but actual values are 10 minutes. Also fix staleTtl comments that said "At 9 minutes" when the staleTtl is only 1 second, and fix "mineutes" typo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monthIndex < 10but outputmonthIndex + 1, so October (index 9) produced010instead of10, breaking all October calendar linksgetLatestReleasesagainst empty data: Replace non-null assertions with optional chaining and add an early return when no nightly/stable release exists, preventing server crashes if the upstream API returns emptysplit('#')[1]with a regex match and add a safe fallback when no PR number can be extracted, preventingNaNfrom being passed to the GitHub API🤖 Generated with Claude Code