Open
Conversation
Change all route Cache-Control headers from `private` to `public` with `s-maxage` and `stale-while-revalidate` to allow Cloudflare to cache responses at the edge. All routes serve public Electron release data with no user-specific content, so this is safe. Also fix timezone detection for Cloudflare proxying: - Prefer CF-Connecting-IP (real client IP) over x-forwarded-for - Use first IP in x-forwarded-for (originating client) not last (proxy) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache-Controlheaders fromprivatetopublicwiths-maxageandstale-while-revalidateto enable Cloudflare edge cachingCF-Connecting-IP(real client IP) instead of the lastx-forwarded-forentry (which would be Cloudflare's edge IP)Context
All routes serve public Electron release data with no user-specific content — the only per-user variance is timezone, which is handled by including the
tzcookie and user geo in the Cloudflare cache key (see electron/infra#195).Cache TTLs
max-ages-maxagestale-while-revalidate🤖 Generated with Claude Code