Skip to content

fix: Print detailed signtool errors #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Print detailed signtool errors #11

wants to merge 1 commit into from

Conversation

felixrieseberg
Copy link
Member

No description provided.

@felixrieseberg felixrieseberg requested a review from a team as a code owner March 8, 2024 01:41
MarshallOfSound
MarshallOfSound requested changes Mar 9, 2024
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Args could include certificate passwords right? We should replace that with * or something if we can detect it (squirrel windows does this for instance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound requested changes

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@erickzhao erickzhao erickzhao approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixrieseberg @MarshallOfSound @BlackHole1 @erickzhao