Skip to content

Conversation

@neilalexander
Copy link
Contributor

Signed-off-by: Neil Alexander [email protected]

@neilalexander neilalexander requested a review from a team as a code owner December 13, 2024 14:11
@neilalexander
Copy link
Contributor Author

neilalexander commented Dec 13, 2024

Waiting on matrix-org/gomatrixserverlib#443 before fixing go.mod. Done.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 44.18605% with 24 lines in your changes missing coverage. Please review.

Project coverage is 49.39%. Comparing base (7acf32f) to head (495c505).

Files with missing lines Patch % Lines
roomserver/internal/input/input_events.go 38.46% 5 Missing and 3 partials ⚠️
clientapi/routing/sendevent.go 25.00% 5 Missing and 1 partial ⚠️
roomserver/internal/perform/perform_upgrade.go 50.00% 2 Missing and 2 partials ⚠️
federationapi/routing/threepid.go 0.00% 2 Missing ⚠️
roomserver/internal/input/input_missing.go 0.00% 2 Missing ⚠️
roomserver/internal/perform/perform_create_room.go 66.66% 0 Missing and 1 partial ⚠️
test/room.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
- Coverage   49.42%   49.39%   -0.04%     
==========================================
  Files         522      522              
  Lines       59472    59488      +16     
==========================================
- Hits        29397    29385      -12     
- Misses      26624    26645      +21     
- Partials     3451     3458       +7     
Flag Coverage Δ
unittests 49.39% <44.18%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit 72039f6 into element-hq:main Dec 15, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants