Skip to content

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Jan 25, 2023

Note the target branch is the push-to-talk POC (feature/ons/ptt_bluetooth)

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Start Element Call widget in it's own task.

Motivation and context

  • So that the push-to-talk call POC can continue running either in the background or in picture-in-picture mode while sending messages to the room.
  • So that pressing back from the home screen does not end the ongoing call or bluetooth connection.

Screenshots / GIFs

N/A

Tests

  • Start a push-to-talk call (see Bluetooth-assisted Push to Talk (PTT) via Element Call #6464)
  • Put the call into PiP or background
  • Go to recent apps
  • Note there are two separate tasks: one for the room and one for the call
  • Navigate to the room task
  • Press back until you see the home screen
  • Note the call is still running (given the Activity has not been destroyed by the OS)

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13, Android 11

Checklist

So that closing the app does not end a PTT call
@jonnyandrew jonnyandrew requested a review from onurays January 25, 2023 12:51
@jonnyandrew jonnyandrew changed the title [PTT] Start widgets in their own task [PTT] Start Element Call widget in its own task Jan 25, 2023
@jonnyandrew jonnyandrew force-pushed the feat/ptt-in-separate-task branch 2 times, most recently from 6a73c5a to 22a0bbb Compare January 25, 2023 14:11
@jonnyandrew jonnyandrew force-pushed the feat/ptt-in-separate-task branch from 22a0bbb to 0c29468 Compare January 25, 2023 14:12
@jonnyandrew jonnyandrew requested a review from onurays January 25, 2023 14:26
@jonnyandrew jonnyandrew merged commit 4cbf692 into feature/ons/ptt_bluetooth Jan 25, 2023
@jonnyandrew jonnyandrew deleted the feat/ptt-in-separate-task branch January 25, 2023 14:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants