Skip to content

Respect isShareKeysOnInviteEnabled() flag when creating new outbound megolm sessions #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Respect isShareKeysOnInviteEnabled() flag when creating new outbound megolm sessions #8540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77a6c67
Respect isShareKeysOnInviteEnabled() flag when creating new outbound …
bradtgmurray Jun 14, 2023
8553db2
Add changelog file
bradtgmurray Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8540.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Respect isShareKeysOnInviteEnabled() flag when creating new outbound megolm sessions in rooms with history sharing enabled
2 changes: 1 addition & 1 deletion ...src/kotlinCrypto/java/org/matrix/android/sdk/internal/crypto/store/db/RealmCryptoStore.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ internal class RealmCryptoStore @Inject constructor(
val info = realm.createObject(OutboundGroupSessionInfoEntity::class.java).apply {
creationTime = clock.epochMillis()
// Store the room history visibility on the outbound session creation
shouldShareHistory = entity.shouldShareHistory
shouldShareHistory = isShareKeysOnInviteEnabled() && entity.shouldShareHistory
putOutboundGroupSession(outboundGroupSession)
}
entity.outboundSessionInfo = info
Expand Down