-
Notifications
You must be signed in to change notification settings - Fork 127
Improve the reliability of state changes in widget mode #3177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,8 +102,8 @@ | |
| "livekit-client": "^2.11.3", | ||
| "lodash-es": "^4.17.21", | ||
| "loglevel": "^1.9.1", | ||
| "matrix-js-sdk": "github:matrix-org/matrix-js-sdk#f3f4a1f7e2f5f2c26cf4fce89a729a9197f619b5", | ||
| "matrix-widget-api": "1.11.0", | ||
| "matrix-js-sdk": "github:matrix-org/matrix-js-sdk#7fa9195e398764749b0195f14d3cf0190ad10253", | ||
| "matrix-widget-api": "^1.13.0", | ||
| "normalize.css": "^8.0.1", | ||
| "observable-hooks": "^4.2.3", | ||
| "pako": "^2.0.4", | ||
|
|
@@ -133,8 +133,7 @@ | |
| }, | ||
| "resolutions": { | ||
| "@livekit/components-core/rxjs": "^7.8.1", | ||
| "@livekit/track-processors/@mediapipe/tasks-vision": "^0.10.18", | ||
| "matrix-widget-api": "1.11.0" | ||
| "@livekit/track-processors/@mediapipe/tasks-vision": "^0.10.18" | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this particular instance it might make sense to mention where exactly the js-sdk commit comes from.
I would almost argue we should make this a procedure rule:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot its not that simple. NONMAIN-... will raise an error as the npm package cannot be found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we might need to find a good place somewhere else. package.json.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different, possibly simpler idea:
Yarn has the ability to reference a Git dependency by branch name rather than commit. We can just use that! Then it's not too difficult to observe that we're using a non-
developbranch and go over to https://github.com/matrix-org/matrix-js-sdk to dig into the details of the branch if you really need them.e4924df
I think Yarn has always had this feature, but in Yarn Classic it caused the package cache to be a bit broken and that's why we always avoided it. But now we're of course on Yarn Berry.