Changing the video codec from VP8 to H.264 #3345
+3
−3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,10 +11,20 @@ import { | |||||
| type RoomOptions, | ||||||
| ScreenSharePresets, | ||||||
| type TrackPublishDefaults, | ||||||
| VideoPreset, | ||||||
| VideoPresets, | ||||||
| } from "livekit-client"; | ||||||
|
|
||||||
| const VideoPresetsH264 = { | ||||||
| h144: new VideoPreset(256, 144, 155_000, 20), | ||||||
| h240: new VideoPreset(480, 234, 160_000, 20), | ||||||
| h176: new VideoPreset(320, 176, 160_000, 20), | ||||||
| h288: new VideoPreset(382, 288, 180_000, 20), | ||||||
| // h360: VideoPresets.h360, | ||||||
| h360: new VideoPreset(640, 360, 450_000, 20), | ||||||
| h540: new VideoPreset(960, 540, 800_000, 20), | ||||||
| } as const; | ||||||
|
|
||||||
| const defaultLiveKitPublishOptions: TrackPublishDefaults = { | ||||||
| audioPreset: AudioPresets.music, | ||||||
| dtx: true, | ||||||
|
|
@@ -23,10 +33,13 @@ const defaultLiveKitPublishOptions: TrackPublishDefaults = { | |||||
| red: false, | ||||||
| forceStereo: false, | ||||||
| simulcast: true, | ||||||
| videoSimulcastLayers: [ | ||||||
| VideoPresetsH264.h144, | ||||||
| VideoPresets.h360, | ||||||
|
||||||
| ] as VideoPreset[], | ||||||
| screenShareEncoding: ScreenSharePresets.h1080fps30.encoding, | ||||||
| stopMicTrackOnMute: false, | ||||||
| videoCodec: "h264", | ||||||
|
There was a problem hiding this comment.
Suggested change
Adding a dev setting for using h264 would allow merging this and would provide us more data on how this behaves in real live. Let me know if I should update this PR. There was a problem hiding this comment. @fkwp any thoughts on this? This would also be nice to have in the 15 release ? |
||||||
| videoEncoding: VideoPresets.h720.encoding, | ||||||
| backupCodec: { codec: "vp8", encoding: VideoPresets.h720.encoding }, | ||||||
| } as const; | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what makes this specific H264 presets? Aren't those just regular presets that could also be used with other encordings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR is in draft -- this is part of debugging why h264 with simulcast is not working on iOS devices.
using h264 specific presets help finding out if the h264 macro-block constraint is the problem here.