Skip to content

Conversation

MrAnno
Copy link

@MrAnno MrAnno commented Oct 2, 2025

This is matrix-org/matrix-react-sdk#8759 once again on the Element Call side.

Fixes #265
Related to #927

Unfortunately, I don't fully understand how to make things reactive in React, so this initial version does not restart audio tracks automatically when the user changes the settings.

@SimonBrandner Could you please help me with a few hints about the correct implementation? :)

Screenshot_20251002_020925

@MrAnno MrAnno requested a review from a team as a code owner October 2, 2025 00:17
@MrAnno MrAnno requested a review from BillCarsonFr October 2, 2025 00:17
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2025

CLA assistant check
All committers have signed the CLA.

@SimonBrandner
Copy link
Contributor

Hi, @MrAnno, unfortunately, I am no longer an active part of the project and do not have much time on my hands atm. I believe @BillCarsonFr will be able to help though :)

@MrAnno
Copy link
Author

MrAnno commented Oct 8, 2025

Bill seems to be busy, so I'll be a bit cheeky and ask whether Robin's in town.

@robintown Hıo ka

@BillCarsonFr
Copy link
Member

Thx @MrAnno, just letting you know that this was added to the things to look at. Looping back with product.
I wonder if we should also add an option to choose max bitRate (like a mode for playing music AudioPresets.musicHighQuality

@MrAnno
Copy link
Author

MrAnno commented Oct 18, 2025

@BillCarsonFr Thanks!

That's a wonderful idea. I tried to keep it minimal because last time it took months to get this through the UX team and I was almost told to compress these three options into a single one.

I would be happy to add any options that result in a better overall sound quality in professional audio environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable noise supression

4 participants