Add multiple screen share previews instead of line indicators - #4131
Open
mgcm wants to merge 1 commit into
Open
Conversation
Signed-off-by: Milton Moura <miltonmoura@gmail.com>
Member
|
Thanks @mgcm, it looks nice. As I told you this is something we want to move forward, will it be ok for you if I merger this PR on a new branch so that we can collaborate to finish the feature?
Regarding your concern for bandwith, let's try to check and get some numbers for the additional bandwith taken by the new low res layer, compared to now |
Contributor
Author
fine by me, do what you must to move the needle 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Usability for showing that a call has multiple active screen shares is not user-friendly nor intuitive.
This PR proposes to have multiple screen share previews below the active spotlight layer, making sure they are tappable / clickable and easily discoverable.
I have iterated on my initial proposal (see #4114) and moved towards the suggested design concept.
My current concern is that by showing other non-active screen share previews, we are now taking up more bandwidth, even if requesting a lower res / fps layer.
Disclaimer
Motivation and context
See #4114
Screenshots / GIFs
Checklist