Potential fix for code scanning alert no. 10: Workflow does not contain permissions #129
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/element-hq/element-modules/security/code-scanning/10
The optimal fix is to restrict the GITHUB_TOKEN permissions as early as possible. This can be done either at the root of the workflow (affecting all jobs) or directly in the
build-pyjob. Since there's only one job shown, adding at the job level is satisfactory. The minimal starting permissions arecontents: read. However, given the workflow pushes Docker images to GitHub Container Registry (ghcr.io), it also needspackages: writepermission (otherwise the Docker push step will fail). Therefore, thepermissionsblock should be added to thebuild-pyjob withcontents: readandpackages: writeset.To implement:
.github/workflows/synapse-module.yml, identify the start of thebuild-pyjob and add apermissions:block configuring least-privilege permissions required, immediately aftername:and beforeruns-on:.Suggested fixes powered by Copilot Autofix. Review carefully before merging.