Skip to content

Document where new linting rules go #23035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2022
Merged

Document where new linting rules go #23035

merged 2 commits into from
Aug 9, 2022

Conversation

@3nprob
Copy link
Contributor

@3nprob 3nprob commented Aug 9, 2022 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

See element-hq/element-desktop#397 (comment), matrix-org/matrix-js-sdk#2573

Type: task

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 9, 2022
@3nprob
Copy link
Contributor Author

3nprob commented Aug 9, 2022 

Signed-off-by: 3nprob <[email protected]>

@3nprob 3nprob force-pushed the document-eslint-rules branch from 4e2abe3 to 1031460 Compare August 9, 2022 10:12
@3nprob 3nprob marked this pull request as ready for review August 9, 2022 10:13
@3nprob 3nprob requested a review from a team as a code owner August 9, 2022 10:13
@github-actions github-actions bot added the T-Task Tasks for the team like planning label Aug 9, 2022
weeman1337
weeman1337 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @3nprob

@weeman1337 weeman1337 merged commit 847e6b0 into element-hq:develop Aug 9, 2022
@3nprob 3nprob deleted the document-eslint-rules branch August 9, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from element-hq/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from element-hq/element-web-reviewers

1 more reviewer

@weeman1337 weeman1337 weeman1337 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@3nprob @weeman1337