Provide RoomViewStore from the RoomContext #30980
Open
+44
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
reviewed
Oct 9, 2025
|
|
||
| const llMembers = context.client.hasLazyLoadMembersEnabled(); | ||
| this.state = { | ||
| roomViewStore: props.roomViewStore, |
There was a problem hiding this comment.
Why putting the store in the state? You can use this.props.roomViewStore in the component
There was a problem hiding this comment.
Because the state is used as the RoomContext, example here.
I have updated the PR description to provide better context.
…eyd/context-provided-room-view-store
langleyd
added
T-Task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
It adds the RoomViewStore to the constructor of RoomView and add's it to the RoomView state which in turn is used as the RoomContext. This means the RoomViewStore can be accessed from the RoomContext within the component hierarchy of the RoomView.. This is needed if are to support multiple RoomViews/RoomViewStores(instead of the singleton RoomViewStore).
A second PR will follow that updates the usages of the RoomViewStore within the RoomView sub-components to use the one from the RoomContext.