Use MatrixRTC slots behind labs flag - #34392
Conversation
| logErrorAndShowErrorDialog(_t("voip|open_slot_failed_title"), e); | ||
| return false; | ||
| } | ||
| }; |
There was a problem hiding this comment.
A lot of this function feels quite generic and that maybe it could go into the js-sdk, and likewise some of the app-specific logic in the hook feels like it could be pulled out to a utility like this.
There was a problem hiding this comment.
Hm, I'm struggling a bit in finding a good way to disentangle the two functions to create a good amount of reuse. Happy to follow any pointers though.
There was a problem hiding this comment.
It seems weird that there's session.getRtcSlot() but then to open a slot you have to manually send a state event. It feels like there ought to be an openRtcSlot() or maybe just this ensureSlotOpen() method on the session?
Also, wouldn't this get any open slot in the room, even if it were a slot for a different RTC application?
There was a problem hiding this comment.
Ok, I think I see what you mean now. Have opened matrix-org/matrix-js-sdk#5524 to extract the ensure methods to the SDK.
7a97e01 to
57d752f
Compare
3 participants
Requires: matrix-org/matrix-js-sdk#5438
Fixes: https://github.com/element-hq/voip-internal/issues/632
Fixes: https://github.com/element-hq/voip-internal/issues/634
This adds a new labs flag that enables the MatrixRTC slot logic from matrix-org/matrix-spec-proposals#4143. Getting this mixed in with the existing branches was a bit hairy. I expect we may have to iterate on the concrete form a little.
Checklist
public/exportedsymbols have accurate TSDoc documentation.