Unified media preview 3 - URL previews use the previews - #34891
Open
Siriusmart wants to merge 18 commits into
Open
Unified media preview 3 - URL previews use the previews#34891Siriusmart wants to merge 18 commits into
Siriusmart wants to merge 18 commits into
Conversation
Siriusmart
requested review from
dbkr and
t3chguy
and removed request for
a team
September 1, 2026 14:08
Siriusmart
force-pushed
the
unified-previews/3-url-preview-tile
branch
from
September 1, 2026 14:52
3e3d482 to
d5ac054
Compare
Siriusmart
force-pushed
the
unified-previews/2-file-body-preview-tile
branch
from
September 1, 2026 14:52
8a2c390 to
b878250
Compare
…-previews/3-url-preview-tile
…-previews/3-url-preview-tile
…-previews/3-url-preview-tile
previewToEntry and the callbacks it hands to the preview group - the lightbox, the open-link button and the collapse toggle - were never reached by a test, because the client mock never resolved a preview. Drop the siteIcon avatar from the composer's inlined LinkSiteName: it was carried over from the shared LinkPreview component, and the only call site here never passes one. Claude-Session: https://claude.ai/code/session_01Gr8zCXinjjNTmAHpZDGNtW
…-previews/3-url-preview-tile
…-previews/3-url-preview-tile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.