Bypass the pnpm version check when installing the linked js-sdk - #34906
Open
nathanael-h wants to merge 1 commit into
Open
Bypass the pnpm version check when installing the linked js-sdk#34906nathanael-h wants to merge 1 commit into
nathanael-h wants to merge 1 commit into
Conversation
The cloned js-sdk may pin a different pnpm version than element-web, and corepack won't switch versions mid-process. Export npm_config_pm_on_fail=ignore so the linked install (and the nested pnpm build from js-sdk's prepare script) proceeds instead of failing the version guard.
github-actions
Bot
added
the
Z-Community-PR
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/docker-link-repos.shclones matrix-js-sdk and runspnpm installinside the clone. That clone pins its own pnpm version indevEngines.packageManager, which can differ from element-web's (currently11.23.0). pnpm won't switch versions mid-process, so the install fails on the version guard rather than proceeding, anddocker-bake/ the linked-SDK Docker build stops there.Set
npm_config_pm_on_fail=ignorefor the js-sdk install so the guard is bypassed instead of fatal. It'sexported rather than passed as a CLI flag so it also covers the nestedpnpm buildthat js-sdk'spreparelifecycle script spawns — that child process hits the same guard.Scoped to the js-sdk clone only: element-web's own installs are untouched, so the pin still applies everywhere it should.
Split out of #32851 at review request — unrelated to that PR's feature work and purely devx.
Checklist
public/exportedsymbols have accurate TSDoc documentation.