Fix OAuth logout bug if started offline - #34918
Draft
dbkr wants to merge 4 commits into
Draft
Conversation
Updates to the js-sdk interface change such that fetching auth metadata and refreshing tokens is now up to the js-sdk with a callback to save the new tokens. Previously we just tried once at startup to fetch auth metadata and powered through if the request failed, meaning we just didn't refresh the tokens, therefore causing the session to be logged out when the access token expired. This leaves it up to the js-sdk to fetch auth metadata when it can, so we don't have to wait for it to be available before starting the client. Fixes #34834
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the js-sdk interface change such that fetching auth metadata and refreshing tokens is now up to the js-sdk with a callback to save the new tokens.
Previously we just tried once at startup to fetch auth metadata and powered through if the request failed, meaning we just didn't refresh the tokens, therefore causing the session to be logged out when the access token expired.
This leaves it up to the js-sdk to fetch auth metadata when it can, so we don't have to wait for it to be available before starting the client.
Fixes #34834
Checklist
public/exportedsymbols have accurate TSDoc documentation.