Skip to content

Annotate Composable functions with @ReadOnlyComposable where it's possible#4859

Merged
bmarty merged 1 commit intodevelopfrom
feature/bma/composeOptimization
Jun 11, 2025
Merged

Annotate Composable functions with @ReadOnlyComposable where it's possible#4859
bmarty merged 1 commit intodevelopfrom
feature/bma/composeOptimization

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Jun 11, 2025

Content

Annotate Composable functions with @ReadOnlyComposable where it's possible

Motivation and context

Improve compose performance hence the gain is probably highly negligible!

Screenshots / GIFs

No change

Tests

  • No change

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner June 11, 2025 09:30
@bmarty bmarty requested review from jmartinesp and removed request for a team June 11, 2025 09:30
@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NLcHM1

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.28%. Comparing base (558e7b9) to head (96967e8).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4859   +/-   ##
========================================
  Coverage    80.27%   80.28%           
========================================
  Files         2140     2140           
  Lines        56917    56922    +5     
  Branches      7164     7164           
========================================
+ Hits         45692    45698    +6     
+ Misses        8790     8789    -1     
  Partials      2435     2435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit f68b411 into develop Jun 11, 2025
31 of 32 checks passed
@bmarty bmarty deleted the feature/bma/composeOptimization branch June 11, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants