Skip to content

Small cleanup around log tag.#4860

Merged
bmarty merged 2 commits intodevelopfrom
feature/bma/extractLogs
Jun 11, 2025
Merged

Small cleanup around log tag.#4860
bmarty merged 2 commits intodevelopfrom
feature/bma/extractLogs

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Jun 11, 2025

What the title says. In particular the second commit in ensuring that the tag is always set.

@bmarty bmarty requested a review from a team as a code owner June 11, 2025 12:57
@bmarty bmarty requested review from ganfra and removed request for a team June 11, 2025 12:57
@bmarty bmarty added the PR-Misc For other changes label Jun 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kpFvvE

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.28%. Comparing base (520c129) to head (4619f06).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...libraries/matrix/impl/RustClientSessionDelegate.kt 25.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4860   +/-   ##
========================================
  Coverage    80.28%   80.28%           
========================================
  Files         2140     2140           
  Lines        56922    56923    +1     
  Branches      7164     7164           
========================================
+ Hits         45698    45699    +1     
  Misses        8789     8789           
  Partials      2435     2435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 920c415 into develop Jun 11, 2025
37 of 39 checks passed
@bmarty bmarty deleted the feature/bma/extractLogs branch June 11, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants