Skip to content

Split WebViewAudioManager#4863

Closed
bmarty wants to merge 5 commits intodevelopfrom
feature/bma/splitWebViewAudioManager
Closed

Split WebViewAudioManager#4863
bmarty wants to merge 5 commits intodevelopfrom
feature/bma/splitWebViewAudioManager

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Jun 11, 2025

Content

Draft

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 26.77596% with 134 lines in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (a8cbd1b) to head (796a7c1).
Report is 60 commits behind head on develop.

Files with missing lines Patch % Lines
...id/features/call/impl/audio/WebViewAudioManager.kt 27.77% 73 Missing and 5 partials ⚠️
...ll/impl/audio/CommunicationDeviceChangedHandler.kt 6.25% 15 Missing ⚠️
...eatures/call/impl/audio/SerializableAudioDevice.kt 0.00% 13 Missing ⚠️
...o/element/android/features/call/impl/audio/Util.kt 0.00% 10 Missing ⚠️
...features/call/impl/audio/WebViewAudioController.kt 60.00% 8 Missing ⚠️
...features/call/impl/audio/WebViewProximitySensor.kt 33.33% 3 Missing and 3 partials ⚠️
...tures/call/impl/audio/AndroidWebViewAudioBridge.kt 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4863      +/-   ##
===========================================
+ Coverage    80.28%   80.29%   +0.01%     
===========================================
  Files         2140     2146       +6     
  Lines        56922    56939      +17     
  Branches      7164     7162       -2     
===========================================
+ Hits         45698    45720      +22     
+ Misses        8789     8777      -12     
- Partials      2435     2442       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/smkqez

@sonarqubecloud
Copy link
Copy Markdown

@bmarty
Copy link
Copy Markdown
Member Author

bmarty commented Jun 17, 2025

I'll do this work again later.

@bmarty bmarty closed this Jun 17, 2025
@bmarty bmarty deleted the feature/bma/splitWebViewAudioManager branch January 9, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant