Skip to content

Another cleanup#4869

Merged
bmarty merged 6 commits intodevelopfrom
feature/bma/anotherCleanup
Jun 12, 2025
Merged

Another cleanup#4869
bmarty merged 6 commits intodevelopfrom
feature/bma/anotherCleanup

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Jun 12, 2025

Content

Remove useless annotations, seems like some APIs are more stable now.
Also remove dead code about message highlight.

Motivation and context

Clean code

Screenshots / GIFs

Tests

  • No expected change in the app behavior.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner June 12, 2025 11:44
@bmarty bmarty requested review from jmartinesp and removed request for a team June 12, 2025 11:44
interactionSource = remember { MutableInteractionSource() },
onClick = {},
onLongClick = {},
)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: there is no diff in the recorded screenshots since this is actually a plain background color like before since isHighlighted had no impact.

@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/sMZc3W

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (770e16d) to head (9005a51).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4869      +/-   ##
===========================================
- Coverage    80.28%   80.27%   -0.01%     
===========================================
  Files         2140     2140              
  Lines        56922    56908      -14     
  Branches      7164     7164              
===========================================
- Hits         45698    45685      -13     
  Misses        8789     8789              
+ Partials      2435     2434       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty added the PR-Misc For other changes label Jun 12, 2025
@bmarty bmarty merged commit 148b3d9 into develop Jun 12, 2025
38 of 39 checks passed
@bmarty bmarty deleted the feature/bma/anotherCleanup branch June 12, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants