Simplify message composer layout

[jmartinesp]

Content

• Remove ExpandableBottomSheetScaffold, which used SubcomposeLayout and some quite complex logic to be able to measure and auto-size the composer in the bottom sheet. Instead, use ExpandableBotttomSheetLayout which uses a simple Layout with IntrinsicContentSize measurements instead.
• This also fixes some weird animations when displaying and hiding the software keyboard.
• Remove extra padding in the RTE layout, which was added because of an issue in ExpandableBottomSheetScaffold.
• Make the whole text box clickable and have it request focus on the actual EditText.

Notes:

• The RTE layout is not full screen anymore, instead it has a max height as in iOS.
• By using the intrinsic content size measurements, we can't have any SubcomposeLayout or LazyList inside the bottom sheet contents, so SuggestionPickerView had to be moved.

Motivation and context

Simplify this layout so it won't break in the next Compose minor release.

Screenshots / GIFs

It should look exactly the same.

Tests

Use the reply, edit and normal writing functionality in both the standard textfield and the RTE. Also try mentioning users.

Tested devices

• Physical
• Emulator
• OS version(s): 14, 16.

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/TtYCAh

[bmarty]

I have tested the code, and it fixes the extra padding issue 🎉 .

One "regression" though:
On my device, I cannot have a RichTextEditor fullscreen as before, i.e. switch to RTE, open the bottom sheet at maximum and close the keyboard. I get this:

and previously I was able to get this:

Also in this state (bottom sheet expanded, and keyboard closed, I cannot open the keyboard. I need to reduce the bottom sheet first. Strange, but not really new apparently.

[jmartinesp]

On my device, I cannot have a RichTextEditor fullscreen as before, i.e. switch to RTE, open the bottom sheet at maximum and close the keyboard. I get this:

This is expected, since we now set a max height for the bottom sheet. This is how it works on iOS, so I hope it's good enough, but the code could probably be tweaked to get actual full screen though.

Also in this state (bottom sheet expanded, and keyboard closed, I cannot open the keyboard. I need to reduce the bottom sheet first. Strange, but not really new apparently.

Oh, I hadn't noticed this. I'll see if I can reproduce it.

---

Now I see the issue: the problem is the actual backing EditText only reaches the same height as the text / existing lines, so tapping on the 'editor box' below where the text reaches does nothing - and it needs to be kept like this to make the intrinsic size measuring work. Maybe I can find a way to map this click event to requesting focus for the EditText.

[codecov]

Codecov Report

Attention: Patch coverage is 75.18519% with 67 lines in your changes missing coverage. Please review.

Project coverage is 80.23%. Comparing base (fb1d076) to head (3e21cc0).
Report is 28 commits behind head on develop.

Files with missing lines	Patch %	Lines
...gnsystem/components/ExpandableBottomSheetLayout.kt	50.00%	42 Missing and 6 partials ⚠️
...ent/android/features/messages/impl/MessagesView.kt	94.44%	4 Missing and 2 partials ⚠️
...tcomposer/components/markdown/MarkdownTextInput.kt	82.75%	0 Missing and 5 partials ⚠️
.../element/android/libraries/androidutils/ui/View.kt	0.00%	2 Missing and 2 partials ⚠️
...ent/android/libraries/textcomposer/TextComposer.kt	86.36%	3 Missing ⚠️
...tem/components/ExpandableBottomSheetLayoutState.kt	90.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4884      +/-   ##
===========================================
- Coverage    80.30%   80.23%   -0.08%     
===========================================
  Files         2161     2162       +1     
  Lines        57471    57504      +33     
  Branches      7232     7233       +1     
===========================================
- Hits         46154    46137      -17     
- Misses        8870     8914      +44     
- Partials      2447     2453       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ganfra]

Thanks, LGTM!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[bmarty]

@jmartinesp It's weird that modifier is used twice here

[jmartinesp]

Oh damn, that first usage should have been a Modifier instead.

[jmartinesp]

#4928