Show generic notification when Event cannot be resolved#4889
Show generic notification when Event cannot be resolved#4889
Conversation
…not be resolved. Previously the error was logged and added to push history but no notification was shown, so the user fully miss the new message.
… internal clear cache.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
| <item quantity="other">"%d notifications"</item> | ||
| </plurals> | ||
| <string name="notification_fallback_content">"Notification"</string> | ||
| <string name="notification_fallback_content">"You have new message(s)."</string> |
There was a problem hiding this comment.
This sounds a bit odd to me, maybe a native speaker could suggest some alternative?
There was a problem hiding this comment.
iirc WhatsApp says You may have new messages which is a less commited variant of the same thing
There was a problem hiding this comment.
@mxandreas / @amshakal any suggestion for this wording? I agree that You may have new messages is probably a better option.
ganfra
left a comment
ganfra
left a comment
There was a problem hiding this comment.
I don't think we should display the battery optimisation banner in those cases
With the fallback notification, we will never show the banner then? |
Is it displayed only once? If the user dismiss it, this won't be shown again on the next fallback notification? This is what I failed to see in the PR, but maybe it's already the case? |
|
Ah OK, yes, it's shown only once. If the user dismiss it (or disable battery optimization) it will not be shown again. If the user clear the cache, it can be shown again (see this commit) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4889 +/- ##
========================================
Coverage 80.29% 80.30%
========================================
Files 2152 2152
Lines 57177 57216 +39
Branches 7199 7201 +2
========================================
+ Hits 45913 45947 +34
- Misses 8821 8826 +5
Partials 2443 2443 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
4 participants
Content
Ensure that when a Push is received and the application is unable to resolve the Event (network error, etc.) the application still shows a notification to the user.
This PR also contain a few more commit around Push, can be reviewed commit per commit
Motivation and context
Less missed messages due to system blocking network request when the application is in background.
Screenshots / GIFs
Notification_fallback.mp4
Tests
Tested devices
Checklist