Change : add tombstoned room decoration

[ganfra]

Content

Follow-up of #4862

Makes sure we are using the correct decoration for tombstoned room :

• When displaying a tombstoned room, the avatar should always be an exclamation mark
• In the room list, when the tombstoned room is not filtered, display "This room has been upgraded"

There are some additional refactoring around Avatar (you can check the commit history) :

• AvatarCluster now replaces part of the CompositeAvatar
• RoomAvatar makes sure to render a room avatar according to the following params :

fun RoomAvatar(
    avatarData: AvatarData,
    heroes: ImmutableList<AvatarData>,
    isTombstoned: Boolean 
)

Also now we use a StateFlow<RoomInfo>, we always have a value, so we don't need to use AsyncData for roomName and avatarData.

Motivation and context

Continuation for #4809
Figma

Screenshots / GIFs

See recorded screenshots.

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mYeEPN

[bmarty]

Nice work thanks!
I believe that the preview must be recorded. I'll check the result, but please add a preview for TombstonedRoomAvatar first.
Thanks!

[bmarty]

Maybe add a Preview for this specific avatar?

[bmarty]

Actually screenshots can't be recorded because AvatarClusterPreview is failing if the number of avatars is not in [1,4]. I let you fix that. Thanks!

[bmarty]

Thanks!

[bmarty]

R became a A, not sure why, but maybe not a problem (?)

[ganfra]

Because RoomAvatar was null before, not possible anymore. So no problem here 👍

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ElementBot]

	Warnings
⚠️	libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/Bloom.kt#L430 - Use the KTX function createBitmap instead?

Generated by 🚫 dangerJS against b8cef93

[codecov]

Codecov Report

Attention: Patch coverage is 91.87817% with 16 lines in your changes missing coverage. Please review.

Project coverage is 80.31%. Comparing base (9133f45) to head (b8cef93).
Report is 15 commits behind head on develop.

Files with missing lines	Patch %	Lines
...es/designsystem/components/avatar/AvatarCluster.kt	86.66%	6 Missing and 2 partials ⚠️
.../features/roomdetails/impl/RoomDetailsPresenter.kt	0.00%	0 Missing and 1 partial ⚠️
...eatures/roomlist/impl/components/RoomSummaryRow.kt	88.88%	0 Missing and 1 partial ⚠️
...list/impl/datasource/RoomListRoomSummaryFactory.kt	0.00%	0 Missing and 1 partial ⚠️
...libraries/designsystem/components/avatar/Avatar.kt	92.85%	0 Missing and 1 partial ⚠️
...aries/designsystem/components/avatar/RoomAvatar.kt	95.65%	0 Missing and 1 partial ⚠️
...aries/designsystem/components/avatar/TextAvatar.kt	95.45%	0 Missing and 1 partial ⚠️
...gnsystem/components/avatar/TombstonedRoomAvatar.kt	90.90%	0 Missing and 1 partial ⚠️
...ndroid/libraries/matrix/ui/model/SelectRoomInfo.kt	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4891      +/-   ##
===========================================
+ Coverage    80.29%   80.31%   +0.01%     
===========================================
  Files         2152     2155       +3     
  Lines        57177    57236      +59     
  Branches      7199     7206       +7     
===========================================
+ Hits         45913    45968      +55     
  Misses        8821     8821              
- Partials      2443     2447       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.