Update dependency org.robolectric:robolectric to v4.16 #5222
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
added
the
PR-Dependencies
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
jmartinesp
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
|
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
| @@ -40,6 +41,6 @@ class AndroidFileSizeFormatter @Inject constructor( | |||
| Formatter.formatShortFileSize(context, normalizedSize) | |||
| } else { | |||
| Formatter.formatFileSize(context, normalizedSize) | |||
| } | |||
| }.replace("kB", "KB") | |||
There was a problem hiding this comment.
Why this replacement? It seems that kB is more correct than KB, since k is the official shortcut for kilo in the international system of units.
There was a problem hiding this comment.
Then I understood the comments on that class and the existing tests backwards, I thought we wanted to keep the KB and 1024 base instead:
// Since Android O, the system considers that 1kB = 1000 bytes instead of 1024 bytes. We want to avoid that.
There was a problem hiding this comment.
In the end did we decide on whether to use 1024 or 1000? I think it was 1000?
There was a problem hiding this comment.
The change from 100 B to 97 B does not seem correct. And we may choose a different test data than 100 for the maxUploadSize, 100 B is not really realistic.
There was a problem hiding this comment.
Previous value with kB is more correct than the new one with KB.
This PR contains the following updates:
4.15.1->4.16Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.