Skip to content

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 8, 2025

Content

Restore code commented out in #5253

Also improve the title rendering

Motivation and context

Fix broken feature, regression reported in #5285 (review)

Screenshots / GIFs

Before After
image image

Tests

  • Open bug report screen
  • Click on "View logs"
  • See the the screen is not empty anymore.
  • Also observe that the title is less long and so not displayed truncated on 3 lines.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 8, 2025 15:01
@bmarty bmarty requested review from ganfra and removed request for a team September 8, 2025 15:01
@bmarty bmarty added Z-NextRelease For issues and PRs which should be included in the NextRelease. PR-Bugfix For bug fix labels Sep 8, 2025
Copy link
Contributor

github-actions bot commented Sep 8, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/KfDRjd

Copy link

sonarqubecloud bot commented Sep 8, 2025

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.65%. Comparing base (f852fb4) to head (e3f7865).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5294   +/-   ##
========================================
  Coverage    79.65%   79.65%           
========================================
  Files         2258     2258           
  Lines        62491    62498    +7     
  Branches      7830     7830           
========================================
+ Hits         49776    49784    +8     
  Misses        9849     9849           
+ Partials      2866     2865    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit cdf79d7 into develop Sep 8, 2025
31 checks passed
@bmarty bmarty deleted the feature/bma/restoreViewLogCode branch September 8, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants