Skip to content

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 9, 2025

Content

Revert AGP to version 8.11.1

Also comment out lint version override. Will help to reduce friction when AGP is upgraded (see #5260 for instance)

Motivation and context

Unblock F-Droid release, see #3420 (comment)

Screenshots / GIFs

NA

Tests

  • NA

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

We should override only when we have an issue with the lint version defined in AGP.
@bmarty bmarty requested a review from a team as a code owner September 9, 2025 16:15
@bmarty bmarty requested review from ganfra and removed request for a team September 9, 2025 16:15
@bmarty bmarty added PR-Build For changes related to build, tools, CI/CD Z-NextRelease For issues and PRs which should be included in the NextRelease. labels Sep 9, 2025
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's hope this fixes f-droid!

@bmarty bmarty enabled auto-merge September 9, 2025 16:21
Copy link
Contributor

github-actions bot commented Sep 9, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3L9Un6

Copy link

sonarqubecloud bot commented Sep 9, 2025

@ElementBot
Copy link
Collaborator

Warnings
⚠️

gradle/libs.versions.toml#L7 - A newer version of com.android.tools.build:gradle than 8.11.1 is available: 8.13.0

⚠️

gradle/libs.versions.toml#L19 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.9.2 is available: 2.9.3

⚠️

gradle/libs.versions.toml#L25 - A newer version of androidx.compose:compose-bom than 2025.07.00 is available: 2025.08.01

⚠️

gradle/libs.versions.toml#L51 - A newer version of com.autonomousapps:dependency-analysis-gradle-plugin than 2.19.0 is available: 3.0.1

⚠️

gradle/libs.versions.toml#L157 - A newer version of org.robolectric:robolectric than 4.15.1 is available: 4.16

⚠️

gradle/libs.versions.toml#L202 - A newer version of io.sentry:sentry-android than 8.21.0 is available: 8.21.1

Generated by 🚫 dangerJS against 2294fd2

@bmarty bmarty merged commit 1bd47ea into develop Sep 9, 2025
41 checks passed
@bmarty bmarty deleted the feature/bma/revertAgpTo_8.11 branch September 9, 2025 16:47
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.65%. Comparing base (c6c1c32) to head (2294fd2).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5311   +/-   ##
========================================
  Coverage    79.65%   79.65%           
========================================
  Files         2259     2259           
  Lines        62506    62506           
  Branches      7833     7833           
========================================
  Hits         49789    49789           
  Misses        9851     9851           
  Partials      2866     2866           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants