Skip to content

Leave space - UI #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 26, 2025
Merged

Leave space - UI #5354

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
74c2ee4
Leave space - Add screen to leave a space.
bmarty Sep 12, 2025
cbd591e
Remove translations (key values have changed).
bmarty Sep 25, 2025
9732d55
Add the (Admin) info.
bmarty Sep 25, 2025
de6f52c
Add unit test on LeaveSpaceState
bmarty Sep 26, 2025
f503bc4
Select all rooms by default
bmarty Sep 26, 2025
5afe213
Update UI
bmarty Sep 26, 2025
b4232a8
Update tests
bmarty Sep 26, 2025
c1678b5
Cleanup to be able to merge.
bmarty Sep 26, 2025
4d1a503
Metro now have `@AssistedInject`.
bmarty Sep 26, 2025
6921117
Update screenshots
ElementBot Sep 26, 2025
0e3efaf
Merge branch 'develop' into feature/bma/leaveSpace
bmarty Sep 26, 2025
c78aa7c
Update screenshots
ElementBot Sep 26, 2025
ef36922
Address review comments.
bmarty Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .../impl/src/main/kotlin/io/element/android/features/space/impl/leave/LeaveSpacePresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ class LeaveSpacePresenter(
roomId = RoomId("!roomId2:example.com"),
),
)
// By default select all rooms
selectedRoomIds.value = rooms.map { it.roomId }.toSet()
Copy link
Member

@jmartinesp jmartinesp Sep 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an immutable set so it won't trigger unnecessary recompositions? As in using ImmutableSet instead of Set for the value.

value = rooms
}
val selectableSpaceRooms by produceState<AsyncData<ImmutableList<SelectableSpaceRoom>>>(
Expand All @@ -86,7 +88,9 @@ class LeaveSpacePresenter(

fun handleEvents(event: LeaveSpaceEvents) {
when (event) {
LeaveSpaceEvents.DeselectAllRooms -> selectedRoomIds.value = emptySet()
LeaveSpaceEvents.DeselectAllRooms -> {
selectedRoomIds.value = emptySet()
}
LeaveSpaceEvents.SelectAllRooms -> {
selectedRoomIds.value = selectableSpaceRooms.dataOrNull()
.orEmpty()
Expand Down