Skip to content

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Sep 19, 2025

Content

Adds some room info to the thread's screen top app bar so the user has some context of what room they're in when a thread is visible.

Motivation and context

Implements #5373.

Screenshots / GIFs

image

Tests

With the Threads feature flag enabled, in a room, open a thread. Check the info displayed matches the actual state of the room.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp requested a review from a team as a code owner September 19, 2025 10:59
@jmartinesp jmartinesp requested review from ganfra and removed request for a team September 19, 2025 10:59
@jmartinesp jmartinesp added the PR-Feature For a new feature label Sep 19, 2025
Copy link
Contributor

github-actions bot commented Sep 19, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FvtiA2

Copy link

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.33%. Comparing base (b5e5350) to head (f089c28).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5374      +/-   ##
===========================================
+ Coverage    80.32%   80.33%   +0.01%     
===========================================
  Files         2274     2274              
  Lines        62861    62892      +31     
  Branches      7865     7867       +2     
===========================================
+ Hits         50493    50525      +32     
  Misses        9466     9466              
+ Partials      2902     2901       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants