Skip to content

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 22, 2025

Content

Change in clear cache behavior:

  • Do not reset the analytics store, so that we do not ask the user consent again => Parity with iOS.
  • Do not reset the permission store, because it contains information that's related to the system permission, which cannot be retrieved otherwise => Should help with Stuck on "Allow notification" screen #3195.

Motivation and context

Follow up for #5379
Closes #3195

Screenshots / GIFs

No change

Tests

  • Login and end up to the room list
  • Clear the cache
  • Observe that the opt-in analytics screen is not displayed anymore.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

- Do not reset the analytics store, so that we do not ask the user consent again => Parity with iOS.
- Do not reset the permission store, because it contains information that's related to the system permission, which cannot be retrieved otherwise => Should help with #3195.
@bmarty bmarty requested a review from a team as a code owner September 22, 2025 09:17
@bmarty bmarty requested review from jmartinesp and removed request for a team September 22, 2025 09:17
@bmarty bmarty added the PR-Bugfix For bug fix label Sep 22, 2025
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/68a3bn

Copy link

Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.37%. Comparing base (c646d6d) to head (290298c).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ment/android/features/ftue/test/FakeFtueService.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5388      +/-   ##
===========================================
- Coverage    80.38%   80.37%   -0.01%     
===========================================
  Files         2276     2276              
  Lines        62926    62910      -16     
  Branches      7874     7873       -1     
===========================================
- Hits         50582    50565      -17     
- Misses        9437     9438       +1     
  Partials      2907     2907              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 9ac1bf6 into develop Sep 22, 2025
34 of 36 checks passed
@bmarty bmarty deleted the feature/bma/fixIssueOnFtueNotificationScreen branch September 22, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck on "Allow notification" screen
2 participants