Skip to content

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 23, 2025

Content

Extract code for the messages view top bar to reduce file size. Create dedicated Preview for the top bar and reduce the number of Preview for MessagesView, for a faster rendering in the IDE.

Motivation and context

Smaller file size
Better performance on rendering previews of MessagesView.
Complement for #5374

Screenshots / GIFs

The recorded one should be OK, and the code coverage should not decrease.

Tests

  • No expected behavior / UI change, it's just some rework.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 23, 2025 19:59
@bmarty bmarty requested review from ganfra and removed request for a team September 23, 2025 19:59
@bmarty bmarty added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Misc For other changes labels Sep 23, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 23, 2025
Copy link
Contributor

github-actions bot commented Sep 23, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/t7fd58

Copy link

Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 96.96970% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.37%. Comparing base (cc38651) to head (321c5f6).
⚠️ Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
...atures/messages/impl/topbars/MessagesViewTopBar.kt 96.82% 0 Missing and 2 partials ⚠️
...oid/features/messages/impl/topbars/ThreadTopBar.kt 96.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5401      +/-   ##
===========================================
- Coverage    80.37%   80.37%   -0.01%     
===========================================
  Files         2282     2284       +2     
  Lines        63069    63066       -3     
  Branches      7887     7887              
===========================================
- Hits         50692    50689       -3     
  Misses        9464     9464              
  Partials      2913     2913              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit a953547 into develop Sep 24, 2025
30 of 31 checks passed
@bmarty bmarty deleted the feature/bma/messagesViewTopBars branch September 24, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants