Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Oct 2, 2025

Also cleanup all our transition handler.

Content

Improve cold start by removing the sliding animation

Motivation and context

Improve UI

Screenshots / GIFs

Tests

  • Kill the app
  • Start the app
  • Observe that the room list / login screen is displayed with a fader animation instead of a slider animation.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

Also cleanup all our transition handler.
@bmarty bmarty requested a review from a team as a code owner October 2, 2025 13:57
@bmarty bmarty removed the request for review from a team October 2, 2025 13:57
@bmarty bmarty added the PR-Misc For other changes label Oct 2, 2025
@bmarty bmarty requested a review from ganfra October 2, 2025 13:57
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/y7DJei

@bmarty bmarty marked this pull request as draft October 2, 2025 14:15
@bmarty
Copy link
Member Author

bmarty commented Oct 2, 2025

Draft as it breaks animation where we may want to keep a slider like when the user signs out.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.07%. Comparing base (73627d9) to head (c108ee4).

Files with missing lines Patch % Lines
...braries/architecture/animation/ScreenTransition.kt 0.00% 3 Missing ⚠️
...ent/android/libraries/architecture/BaseFlowNode.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5447      +/-   ##
===========================================
- Coverage    81.07%   81.07%   -0.01%     
===========================================
  Files         2317     2317              
  Lines        63628    63630       +2     
  Branches      8032     8032              
===========================================
  Hits         51588    51588              
- Misses        9104     9106       +2     
  Partials      2936     2936              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frebib
Copy link
Contributor

frebib commented Oct 3, 2025

I tried this out and immediately noticed that the room list doesn't slide left when opening and closing rooms. It's not bad; just a bit different. Is that an intentional side-effect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants