Skip to content

Conversation

@jmartinesp
Copy link
Member

Content

  • Stop ongoing updates and remove pending ones on the room list when we receive either a Reset or Clear update.
  • Improve the RoomListEntriesUpdate.describe() method so it prints the room ids too.
  • Apply the updates using the computation dispatcher, not the IO one.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

- Stop ongoing updates and remove pending ones on the room list when we receive either a `Reset` or `Clear` update.
- Improve the `RoomListEntriesUpdate.describe()` method so it prints the room ids too.
- Apply the updates using the computation dispatcher, not the IO one.
@jmartinesp jmartinesp changed the title Try improving room list performance: Try improving room list performance Oct 14, 2025
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/e8znF1

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.80%. Comparing base (35cf3ae) to head (4e563e1).

Files with missing lines Patch % Lines
...s/matrix/impl/roomlist/RoomSummaryListProcessor.kt 85.71% 1 Missing and 3 partials ⚠️
...s/matrix/impl/roomlist/RoomListEntriesUpdateExt.kt 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5534      +/-   ##
===========================================
- Coverage    81.80%   81.80%   -0.01%     
===========================================
  Files         2371     2372       +1     
  Lines        67278    67305      +27     
  Branches      8197     8202       +5     
===========================================
+ Hits         55040    55062      +22     
- Misses        9193     9195       +2     
- Partials      3045     3048       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants