Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Oct 29, 2025

Content

Fix issue on brand color override and enable Konsist test.

Motivation and context

The issue was not visible since # was not necessary, but let's be consistent in the color format.

Screenshots / GIFs

No impact.

Tests

  • No change.

Tested devices

NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 29, 2025 11:27
@bmarty bmarty added the PR-Misc For other changes label Oct 29, 2025
@bmarty bmarty requested review from ganfra and removed request for a team October 29, 2025 11:27
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/y11epY

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.70%. Comparing base (7baae58) to head (e38c385).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5626   +/-   ##
========================================
  Coverage    81.70%   81.70%           
========================================
  Files         2391     2391           
  Lines        64948    64948           
  Branches      8253     8253           
========================================
  Hits         53063    53063           
  Misses        8825     8825           
  Partials      3060     3060           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants