Skip to content

Conversation

@jmartinesp
Copy link
Member

Content

Remove this rule, which doesn't really do anything anymore AFAICT.

Motivation and context

Does as much of #5705 as we can.

Tests

Build the app in release mode, it should keep working as expected.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 15

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp requested a review from a team as a code owner November 10, 2025 11:15
@jmartinesp jmartinesp added the PR-Misc For other changes label Nov 10, 2025
@jmartinesp jmartinesp requested review from bmarty and removed request for a team November 10, 2025 11:15
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Y2TVk7

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.61%. Comparing base (516fc72) to head (f787eb2).
⚠️ Report is 94 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5707      +/-   ##
===========================================
- Coverage    79.65%   79.61%   -0.05%     
===========================================
  Files         2427     2427              
  Lines        65212    65212              
  Branches      8318     8318              
===========================================
- Hits         51945    51917      -28     
- Misses       10291    10318      +27     
- Partials      2976     2977       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp
Copy link
Member Author

  • Coverage 79.65% 79.61% -0.05%

Huh, I guess it wasn't that unused then 👀

@jmartinesp jmartinesp marked this pull request as draft November 10, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants