-
Notifications
You must be signed in to change notification settings - Fork 338
Add alert to encrypted rooms with visible history (Android). #5709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kaylendog
wants to merge
9
commits into
element-hq:develop
Choose a base branch
from
kaylendog:kaylendog/history-sharing/alert-impl
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add alert to encrypted rooms with visible history (Android). #5709
kaylendog
wants to merge
9
commits into
element-hq:develop
from
kaylendog:kaylendog/history-sharing/alert-impl
+452
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
kaylendog
commented
Nov 10, 2025
appconfig/src/main/kotlin/io/element/android/appconfig/LearnMoreConfig.kt
Outdated
Show resolved
Hide resolved
kaylendog
commented
Nov 10, 2025
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.map | ||
|
|
||
| interface HistoryVisibleAcknowledgementRepository { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is the correct naming scheme to use?
kaylendog
commented
Nov 10, 2025
...otlin/io/element/android/features/messages/impl/crypto/historyvisible/HistoryVisibleState.kt
Outdated
Show resolved
Hide resolved
3 tasks
- Adds a dismissable alert that is displayed whenever the user opens a room with `history_visibility` != `joined`. When cleared, this is recorded in the app's data store. - When opening a room with `history_visibility` = `joined`, this flag is cleared.` Issue: element-hq/element-meta#2875
6c4104a to
46fba48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T-Enhancement
New features, changes in functionality, performance boosts, user-facing improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
history_visibility!=joined. When cleared, this is recorded in the app's data store.history_visibility=joined, this flag is cleared.`Motivation and context
This is part of ongoing work to implement production-ready encrypted room history.
Issue: element-hq/element-meta#2875
Screenshots / GIFs
Tests
invitedhistory visibility, the new banner should be visible immediately upon opening the room.Tested devices
Checklist