Module cleanup

[bmarty]

Content

Ensure that :api modules do not contain implementation. Implementation should be located in :impl modules.
We may discuss internally if this is making sense or not.

Motivation and context

Clean archi.

Screenshots / GIFs

No expected change

Tests

No expected impact

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PzXWfB

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 78.94737% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.59%. Comparing base (7b7c429) to head (df11dbd).

Files with missing lines	Patch %	Lines
...d/libraries/mediaupload/impl/DefaultMediaSender.kt	83.72%	18 Missing and 3 partials ⚠️
...braries/recentemojis/impl/DefaultAddRecentEmoji.kt	0.00%	5 Missing ⚠️
...roid/libraries/mediaupload/test/FakeMediaSender.kt	60.00%	4 Missing ⚠️
...s/mediaupload/impl/DefaultMaxUploadSizeProvider.kt	0.00%	3 Missing ⚠️
...vices/appnavstate/impl/DefaultActiveRoomsHolder.kt	75.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5722      +/-   ##
===========================================
- Coverage    79.63%   79.59%   -0.05%     
===========================================
  Files         2431     2434       +3     
  Lines        65261    65283      +22     
  Branches      8332     8332              
===========================================
- Hits         51972    51963       -9     
- Misses       10308    10339      +31     
  Partials      2981     2981              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.