Skip to content

Conversation

@ganfra
Copy link
Member

@ganfra ganfra commented Nov 13, 2025

Content

This PR introduces several improvements regarding room member list :

  • tapping a banned member will display the same bottomsheet than for a non-banned member
  • tapping unban action now offers a dialog with a reason textfield
  • makes sure member list is fully reactive
  • update designs for moderation dialogs

Motivation and context

Alignement with iOS and improvements.

Screenshots / GIFs

See recorded ones.

Tests

  • Open the room member list from a room you're admin
  • Play with the moderation actions
  • Ensure the member list is refreshed correctly and ui matches design

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added the PR-Change For updates to an existing feature label Nov 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VctwVC

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 36.80000% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.57%. Comparing base (8638c06) to head (b33388b).

Files with missing lines Patch % Lines
...atrix/impl/timeline/MatrixTimelineDiffProcessor.kt 0.00% 55 Missing ⚠️
...oid/libraries/matrix/impl/timeline/RustTimeline.kt 0.00% 12 Missing ⚠️
...droid/libraries/matrix/impl/room/JoinedRustRoom.kt 0.00% 8 Missing ⚠️
...sandpermissions/impl/roles/ChangeRolesPresenter.kt 81.25% 1 Missing and 2 partials ⚠️
...ermoderation/impl/RoomMemberModerationPresenter.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5728      +/-   ##
===========================================
- Coverage    79.65%   79.57%   -0.08%     
===========================================
  Files         2433     2432       -1     
  Lines        65282    65325      +43     
  Branches      8329     8326       -3     
===========================================
- Hits         52000    51984      -16     
- Misses       10302    10360      +58     
- Partials      2980     2981       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 13, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 13, 2025
@sonarqubecloud
Copy link

@ganfra ganfra marked this pull request as ready for review November 13, 2025 19:00
@ganfra ganfra requested a review from a team as a code owner November 13, 2025 19:00
@ganfra ganfra requested review from bmarty and removed request for a team November 13, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Change For updates to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants