Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Dec 29, 2025

Content

Fix issue preventing notifications to be displayed.

Motivation and context

Fixes #5955

Screenshots / GIFs

Tests

  • Receive a message that should trigger a notification
  • if a notification is displayed, the issue is fixed.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

java.lang.ClassCastException: io.element.android.libraries.androidutils.json.DefaultJsonProvider cannot be cast to kotlinx.serialization.json.Json
@bmarty bmarty requested a review from a team as a code owner December 29, 2025 11:02
@bmarty bmarty requested review from jmartinesp and removed request for a team December 29, 2025 11:02
@bmarty bmarty added Z-NextRelease For issues and PRs which should be included in the NextRelease. PR-Bugfix For bug fix labels Dec 29, 2025
@bmarty bmarty requested review from ganfra and removed request for jmartinesp December 29, 2025 11:02
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fU2mJ4

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.40%. Comparing base (b5b765e) to head (7458586).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5958   +/-   ##
========================================
  Coverage    81.40%   81.40%           
========================================
  Files         2535     2535           
  Lines        67624    67624           
  Branches      8669     8669           
========================================
+ Hits         55049    55050    +1     
  Misses        9365     9365           
+ Partials      3210     3209    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 5ced2cc into develop Dec 29, 2025
31 of 32 checks passed
@bmarty bmarty deleted the feature/bma/fixNotificationRegression branch December 29, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix Z-NextRelease For issues and PRs which should be included in the NextRelease.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClassCastException on triggering push notification on nightly

3 participants