Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Jan 2, 2026

Content

First commit: cleanup.
Second commit: Ensure that avatars always have a content description.

Motivation and context

Closes https://github.com/element-hq/customer-success/issues/549

Screenshots / GIFs

Tests

  • Enalbe TalkBack / ScreenReader
  • Navigate to the room details of a room with no avatar defined
  • Click on the avatar
  • Observe that the avatar is focusable and a text is said.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner January 2, 2026 15:25
@bmarty bmarty requested review from jmartinesp and removed request for a team January 2, 2026 15:25
@bmarty bmarty added the PR-Misc For other changes label Jan 2, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wWDHp6

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.36%. Comparing base (f47b913) to head (0044875).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5968   +/-   ##
========================================
  Coverage    81.36%   81.36%           
========================================
  Files         2535     2535           
  Lines        67626    67626           
  Branches      8669     8664    -5     
========================================
+ Hits         55022    55023    +1     
  Misses        9394     9394           
+ Partials      3210     3209    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit cf4e54f into develop Jan 5, 2026
36 of 37 checks passed
@bmarty bmarty deleted the feature/bma/a11y/letterAvatar branch January 5, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants