Skip to content

Conversation

@jmartinesp
Copy link
Member

Content

Avoids discarding the verified state if the encryption layer is not fully loaded.

This can't be a false positive like VerificationState.UNKNOWN or VerificationState.UNVERIFIED, so it makes sense to return it as fast as possible.

Motivation and context

Fixes an issue that caused long room list UI loading times.

Tests

Open the app in a cold start. It should display the contents almost immediately, or at least way faster than before, specially with bad network connectivity.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 16

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

This can't be a false positive like `VerificationState.UNKNOWN` or `VerificationState.UNVERIFIED`, so it makes sense to return it as fast as possible instead of waiting for the whole encryption layer to be fully loaded.
@jmartinesp jmartinesp requested a review from a team as a code owner January 5, 2026 14:33
@jmartinesp jmartinesp requested review from bmarty and removed request for a team January 5, 2026 14:33
@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Jan 5, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Xxbu5h

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmartinesp jmartinesp enabled auto-merge (squash) January 5, 2026 14:49
@jmartinesp jmartinesp merged commit 8955fb1 into develop Jan 5, 2026
34 of 35 checks passed
@jmartinesp jmartinesp deleted the fix/use-verified-state-if-available branch January 5, 2026 15:06
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.36%. Comparing base (cf4e54f) to head (b0d894d).
⚠️ Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
...mpl/verification/RustSessionVerificationService.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5973      +/-   ##
===========================================
- Coverage    81.40%   81.36%   -0.04%     
===========================================
  Files         2535     2535              
  Lines        67626    67626              
  Branches      8664     8664              
===========================================
- Hits         55051    55024      -27     
- Misses        9367     9394      +27     
  Partials      3208     3208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants