-
Notifications
You must be signed in to change notification settings - Fork 369
Change Room’s Access to/from Space members #5979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
# Conflicts: # features/roomdetails/impl/src/main/res/values/localazy.xml # features/securityandprivacy/impl/src/main/res/values/localazy.xml # libraries/ui-strings/src/main/res/values/localazy.xml
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5979 +/- ##
===========================================
+ Coverage 81.34% 81.41% +0.06%
===========================================
Files 2545 2551 +6
Lines 67792 68119 +327
Branches 8683 8740 +57
===========================================
+ Hits 55146 55458 +312
+ Misses 9426 9417 -9
- Partials 3220 3244 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Move authorized space selection state to a shared StateHolder scoped to RoomScope. This simplifies communication between SecurityAndPrivacy and ManageAuthorizedSpaces nodes by replacing the complex coroutine-based parent-child coordination with a reactive state flow pattern.
|



Content
This PR allows to change the room access of a room/space to SpaceMembers, aka Restricted.
It also supports the knockRestricted feature.
Motivation and context
Closes #5650
Screenshots / GIFs
See recorded screenshots.
Tests
Tested devices
Checklist