Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Jan 8, 2026

Content

Improve IconButton on the composer area regarding accessibility focus when the screen reader is enabled and when the user is navigating with a keyboard.

Motivation and context

Closes https://github.com/element-hq/customer-success/issues/556

Screenshots / GIFs

Tests

Using the emulator

  • Open a room timeline
  • Using the keyboard arrows, navigate to the microphone icon to start recording a voice message.
  • Pressing the space bar of the keyboard, you should be able to start recording, stop recording and send the voice message without losing the focus on the icon.

When a voice message as been recorded but not sent, you should be able to navigate to the play icon and press the space bar several times to start/pause the playback without losing the focus

When a voice message as been recorded but not sent, you should be able to navigate to bin icon and press the space bar to delete the pending voice message without losing the focus, which is still on the same icon area. The icon is now the "Attachement" icon.

Using a real device with screen reader enabled

You should be able to perform the same actions using a real device with screen reader enabled.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner January 8, 2026 13:53
@bmarty bmarty added the PR-Misc For other changes label Jan 8, 2026
@bmarty bmarty requested review from ganfra and removed request for a team January 8, 2026 13:53
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/shXi96

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 79.64602% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.35%. Comparing base (8a290c3) to head (39d36b2).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...ent/android/libraries/textcomposer/TextComposer.kt 67.14% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5980      +/-   ##
===========================================
+ Coverage    81.33%   81.35%   +0.02%     
===========================================
  Files         2545     2545              
  Lines        67760    67763       +3     
  Branches      8684     8694      +10     
===========================================
+ Hits         55113    55130      +17     
+ Misses        9429     9417      -12     
+ Partials      3218     3216       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants