-
Notifications
You must be signed in to change notification settings - Fork 423
Support for Voice Call only (no video), parity with web #5995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+598
−230
Merged
Changes from 16 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5491040
WIP: Support using Element Call for voice calls in DMs
BillCarsonFr 7ef43ab
Support incoming audio only calls
BillCarsonFr be37091
rename voiceIntent to isAudioCall
BillCarsonFr 0e3722e
Merge branch 'develop' into valere/rtc/voice_call
BillCarsonFr 22a9e54
fix missing rename of var
BillCarsonFr fdd39fa
on show voice call only option in DMs
BillCarsonFr 284420d
bump rust sdk bindings to 26.03.4
BillCarsonFr ccc276f
remove a done TODO comment
BillCarsonFr 1f4601c
konsist: fix PreviewParameterProvider naming convention
BillCarsonFr f81f79f
fix tests
BillCarsonFr 6bf7060
Update screenshots
ElementBot 7897101
fix test for voice call button
BillCarsonFr 0e5b3be
Merge branch 'develop' into valere/rtc/voice_call
BillCarsonFr c67a76f
fix call state presenter test
BillCarsonFr dd0143b
fix RoomDetailsViewTest
BillCarsonFr 8743110
fix tests
BillCarsonFr 79d8ec1
review: Rename aIncomingCallScreenState to aCallNotificationData
BillCarsonFr 4406b50
review: fix bad usage of modifier
BillCarsonFr bad6085
review: consistency use isAudioCall everywhere (instead of voiceOnly)
BillCarsonFr 14cea29
Merge branch 'develop' into valere/rtc/voice_call
BillCarsonFr 9504984
Merge branch 'develop' into valere/rtc/voice_call
BillCarsonFr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
.../src/main/kotlin/io/element/android/features/call/impl/ui/CallNotificationDataProvider.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Copyright (c) 2026 Element Creations Ltd. | ||
| * | ||
| * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial. | ||
| * Please see LICENSE files in the repository root for full details. | ||
| */ | ||
|
|
||
| package io.element.android.features.call.impl.ui | ||
|
|
||
| import androidx.compose.ui.tooling.preview.PreviewParameterProvider | ||
| import io.element.android.features.call.impl.notifications.CallNotificationData | ||
| import io.element.android.libraries.matrix.api.core.EventId | ||
| import io.element.android.libraries.matrix.api.core.RoomId | ||
| import io.element.android.libraries.matrix.api.core.SessionId | ||
| import io.element.android.libraries.matrix.api.core.UserId | ||
|
|
||
| open class CallNotificationDataProvider : PreviewParameterProvider<CallNotificationData> { | ||
| override val values: Sequence<CallNotificationData> | ||
| get() = sequenceOf( | ||
| aIncomingCallScreenState( | ||
| audioOnly = false | ||
| ), | ||
| aIncomingCallScreenState( | ||
| audioOnly = true | ||
| ), | ||
| ) | ||
| } | ||
|
|
||
| internal fun aIncomingCallScreenState( | ||
| audioOnly: Boolean | ||
| ): CallNotificationData { | ||
| return CallNotificationData( | ||
| sessionId = SessionId("@alice:matrix.org"), | ||
| roomId = RoomId("!1234:matrix.org"), | ||
| eventId = EventId("\$asdadadsad:matrix.org"), | ||
| senderId = UserId("@bob:matrix.org"), | ||
| roomName = "A room", | ||
| senderName = "Bob", | ||
| avatarUrl = null, | ||
| notificationChannelId = "incoming_call", | ||
| timestamp = 0L, | ||
| textContent = null, | ||
| expirationTimestamp = 1000L, | ||
| audioOnly = audioOnly | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the function to
aCallNotificationDataThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 79d8ec1