Skip to content

Conversation

@ganfra
Copy link
Member

@ganfra ganfra commented Feb 6, 2026

Content

Iterate on space ui with the following changes:

  • Introduce RoomPreviewAliasAtom with copy-to-clipboard feature
  • Update EmptySpaceView design to match Figma specifications
  • Add border to SpaceAvatar for better visual distinction
  • Update SpaceRoom visibility related UI
  • Update ConfigureRoomView space selection

Also makes sure creating a room in a space is considered as a Private room.

Motivation and context

Closes #6128
Handles element-hq/element-meta#3106
Handles element-hq/element-meta#3107
Handles element-hq/element-meta#3108
Handles element-hq/element-meta#3111
Handles element-hq/element-meta#3113

Screenshots / GIFs

See recorded screenshots.

Tests

  • Just browse all space features I guess

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Change For updates to an existing feature labels Feb 6, 2026
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Aapioo

@ganfra ganfra marked this pull request as ready for review February 6, 2026 12:10
@ganfra ganfra requested a review from a team as a code owner February 6, 2026 12:10
@ganfra ganfra requested review from bmarty and removed request for a team February 6, 2026 12:10
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 93.05556% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.37%. Comparing base (5566f10) to head (1b03f63).
⚠️ Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
.../designsystem/atomic/atoms/RoomPreviewAliasAtom.kt 81.48% 3 Missing and 2 partials ⚠️
...eroom/impl/configureroom/ConfigureRoomPresenter.kt 92.10% 0 Missing and 3 partials ⚠️
...teroom/impl/configureroom/CreateRoomConfigStore.kt 66.66% 1 Missing and 1 partial ⚠️
...m/impl/configureroom/ConfigureRoomStateProvider.kt 90.90% 0 Missing and 1 partial ⚠️
...createroom/impl/configureroom/ConfigureRoomView.kt 96.29% 0 Missing and 1 partial ⚠️
...ures/createroom/impl/configureroom/JoinRuleItem.kt 85.71% 1 Missing ⚠️
...ment/android/features/space/impl/root/SpaceView.kt 94.73% 0 Missing and 1 partial ⚠️
...libraries/matrix/api/spaces/SpaceRoomVisibility.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6150   +/-   ##
========================================
  Coverage    81.37%   81.37%           
========================================
  Files         2569     2569           
  Lines        69700    69733   +33     
  Branches      8963     8961    -2     
========================================
+ Hits         56716    56747   +31     
- Misses        9650     9654    +4     
+ Partials      3334     3332    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ganfra ganfra marked this pull request as draft February 6, 2026 12:11
@ganfra ganfra removed the request for review from bmarty February 6, 2026 12:12
@ganfra ganfra force-pushed the feature/fga/space_ui_tweaks branch from 072ea17 to d38579c Compare February 9, 2026 11:08
@ganfra ganfra force-pushed the feature/fga/space_ui_tweaks branch from d38579c to 04ae1b1 Compare February 9, 2026 19:48
@ganfra ganfra marked this pull request as ready for review February 9, 2026 19:48
@ganfra ganfra requested review from a team and bmarty and removed request for a team February 9, 2026 19:48
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 9, 2026
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 9, 2026
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@ganfra ganfra enabled auto-merge February 10, 2026 09:07
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 10, 2026
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 10, 2026
@sonarqubecloud
Copy link

@ganfra ganfra merged commit b271e06 into develop Feb 10, 2026
30 checks passed
@ganfra ganfra deleted the feature/fga/space_ui_tweaks branch February 10, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Change For updates to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Update the designs for a space without rooms

3 participants