Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Feb 9, 2026

Reorder some when cases.

Content

QRCode login: treat not found error as expired error.
Note: the mapping was already correct for the link new device use story (see here)

Motivation and context

Closes #6159
iOS PR: element-hq/element-x-ios#5070

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner February 9, 2026 14:16
@bmarty bmarty removed the request for review from a team February 9, 2026 14:16
@bmarty bmarty added the PR-Change For updates to an existing feature label Feb 9, 2026
@bmarty bmarty requested a review from ganfra February 9, 2026 14:16
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rLci7k

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.37%. Comparing base (d693aee) to head (0311fc9).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ibraries/matrix/impl/auth/qrlogin/QrErrorMapper.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6161   +/-   ##
========================================
  Coverage    81.36%   81.37%           
========================================
  Files         2569     2569           
  Lines        69700    69700           
  Branches      8963     8963           
========================================
+ Hits         56713    56715    +2     
+ Misses        9654     9650    -4     
- Partials      3333     3335    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 20406ec into develop Feb 9, 2026
35 of 37 checks passed
@bmarty bmarty deleted the feature/bma/notFoundMapping branch February 9, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Change For updates to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mapping for Sign in with QR/Link new device NotFound error

2 participants