Rely on the SessionObserver to detect a sign out.

[bmarty]

Content

Rely on the SessionObserver to detect a sign out.

Motivation and context

Relying on the navigation state was not working since the owner of the state is not the same.

Screenshots / GIFs

Tests

• Sign in to account 1
• Sign in to account 2
• Let account 2 get some notification displayed
• Sign out from account 2

Observe that the notification for account 2 are correctly dismissed. It was not the case with the previous code.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yfjPVz

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.39%. Comparing base (d304977) to head (40d8722).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6182      +/-   ##
===========================================
- Coverage    81.39%   81.39%   -0.01%     
===========================================
  Files         2570     2570              
  Lines        69759    69759              
  Branches      8969     8968       -1     
===========================================
- Hits         56780    56779       -1     
- Misses        9644     9647       +3     
+ Partials      3335     3333       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.