Fix call button color and ensure call can always be declined from the notification#6195
Merged
Fix call button color and ensure call can always be declined from the notification#6195
Conversation
…killed when the call is ringing.
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Member
|
God, it looked terrible in landscape. Now it's better, but it still feels weird, maybe we should ask design to enforce portrait mode here 😅 . |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6195 +/- ##
===========================================
- Coverage 81.41% 81.41% -0.01%
===========================================
Files 2569 2569
Lines 69701 69712 +11
Branches 8942 8944 +2
===========================================
+ Hits 56750 56754 +4
- Misses 9630 9636 +6
- Partials 3321 3322 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Content
Use correct color for the incoming call screen buttons. Also improve the UI rendering in wide screen / landscape.
Ensure that the call can be declined from the notification. It was not working in some cases.
Motivation and context
Nicer UI, working notification action
Screenshots / GIFs
In landscape, the incoming call screen is less ugly
Tests
If the call is declined and the notification is dismissed, the bug is fixed.
Tested devices
Checklist