Skip to content

Fix call button color and ensure call can always be declined from the notification#6195

Merged
bmarty merged 7 commits intodevelopfrom
feature/bma/callButtonColor
Feb 12, 2026
Merged

Fix call button color and ensure call can always be declined from the notification#6195
bmarty merged 7 commits intodevelopfrom
feature/bma/callButtonColor

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Feb 12, 2026

Content

Use correct color for the incoming call screen buttons. Also improve the UI rendering in wide screen / landscape.

Ensure that the call can be declined from the notification. It was not working in some cases.

Motivation and context

Nicer UI, working notification action

Screenshots / GIFs

In landscape, the incoming call screen is less ugly

Before After
Screenshot_20260212_160505 Screenshot_20260212_160945

Tests

  • Make sure the phone is not locked, the screen is on.
  • Receive an Element Call
  • When the notification to accept/decline the call is displayed
  • From the task switcher, kill Element X
  • Attempt to decline the call from the notification.

If the call is declined and the notification is dismissed, the bug is fixed.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner February 12, 2026 16:43
@bmarty bmarty requested review from jmartinesp and removed request for a team February 12, 2026 16:43
@bmarty bmarty added the PR-Bugfix For bug fix label Feb 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vARin1

@jmartinesp
Copy link
Member

God, it looked terrible in landscape. Now it's better, but it still feels weird, maybe we should ask design to enforce portrait mode here 😅 .

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.41%. Comparing base (7d58464) to head (459e70f).
⚠️ Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
...all/impl/receivers/DeclineCallBroadcastReceiver.kt 0.00% 5 Missing ⚠️
...roid/features/call/impl/utils/ActiveCallManager.kt 71.42% 2 Missing and 2 partials ⚠️
...roid/features/call/impl/ui/IncomingCallActivity.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6195      +/-   ##
===========================================
- Coverage    81.41%   81.41%   -0.01%     
===========================================
  Files         2569     2569              
  Lines        69701    69712      +11     
  Branches      8942     8944       +2     
===========================================
+ Hits         56750    56754       +4     
- Misses        9630     9636       +6     
- Partials      3321     3322       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit fc6e4e2 into develop Feb 12, 2026
29 of 32 checks passed
@bmarty bmarty deleted the feature/bma/callButtonColor branch February 12, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants